Avoid many failing tests in doctesting #27262
Conversation
utils/not_doctested.txt
Outdated
| docs/source/en/tasks/asr.md | ||
| docs/source/en/tasks/audio_classification.md | ||
| docs/source/en/tasks/document_question_answering.md | ||
| docs/source/en/tasks/idefics.md # cause other test failing |
There was a problem hiding this comment.
allow to add comment (despite not very pretty)
| @@ -54,7 +54,7 @@ def clean_doctest_list(doctest_file: str, overwrite: bool = False): | |||
| all_paths = [] | |||
| with open(doctest_file, "r", encoding="utf-8") as f: | |||
| for line in f: | |||
| line = line.strip() | |||
| line = line.strip().split(" ")[0] | |||
There was a problem hiding this comment.
take into account the potential comments in some lines of utils/not_doctested.txt
| removed_content = set(old_content.split("\n")) - set(new_content.split("\n")) | ||
| removed_content = {x.split(" ")[0] for x in old_content.split("\n")} - { | ||
| x.split(" ")[0] for x in new_content.split("\n") | ||
| } |
There was a problem hiding this comment.
same: deal with the potential comments
utils/not_doctested.txt
Outdated
| src/transformers/models/blip/modeling_tf_blip_text.py | ||
| src/transformers/models/blip_2/configuration_blip_2.py | ||
| src/transformers/models/blip_2/convert_blip_2_original_to_pytorch.py | ||
| src/transformers/models/blip_2/modeling_blip_2.py # cause other test failing |
There was a problem hiding this comment.
currently, src/transformers/models/blip_2/modeling_blip_2.py and docs/source/en/tasks/idefics.md cause problem to other tests
|
The documentation is not available anymore as the PR was closed or merged. |
utils/not_doctested.txt
Outdated
| docs/source/en/tasks/asr.md | ||
| docs/source/en/tasks/audio_classification.md | ||
| docs/source/en/tasks/document_question_answering.md | ||
| docs/source/en/tasks/idefics.md # cause other test failing |
There was a problem hiding this comment.
I'm not able to parse this comment is it saying:
- Because other tests are failing
or - Causes other tests to fail
?
There was a problem hiding this comment.
these 2 files, if run in doctesting, cause other tests to fail.
I will change it to causes other tests to fail
* fix * update * update * fix --------- Co-authored-by: ydshieh <[email protected]>
What does this PR do?
Avoid many failing tests in doctesting: currently, src/transformers/models/blip_2/modeling_blip_2.py and docs/source/en/tasks/idefics.md cause problem to other tests
With this PR: the failing list is much shorter
Currently failing tests without this PR